jyn
jyn
Some discussion about how to make this possible in https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/tell.20the.20trait.20system.20functions.20and.20Write.20are.20disjoint.3F. It would need changes in the standard library, so definitely a long-term improvement.
There has been some recent progress on this: https://zulip-archive.rust-lang.org/243200tlangmajorchanges/08462negativeimplsintegratedintocoherencelangteam96.html. The next steps are for the feature to be implemented and for the standard library to add `impl !FnMut for &str...
Another alternative is for lol-html to add its own custom trait that's implemented for functions and Vec.
Thanks for the PR! https://github.com/cloudflare/lol-html/pull/112 fixes the formatting, can you rebase over master so the PR only has your own changes? > This adds an on_after_end_tag handler to address #108....
> first, we need to link to module instead of trait, in top page. (like io, channel, executor, etc.). Sure, that could work. > next, we need to improve module...
> This would be incredibly useful for docs.rs as we're looking into switching to `lol_html` because of its performance and resource usage bonuses, has there been any progress? We ended...
@inikulin I'm not sure I follow - this is used in `src/parser/state_machine/syntax/doctype.rs`, it sets `force_quirks` if it sees `>` in a doctype without seeing an ident first.
Hmm, this seems to work fine as-is - I ran `examples/mixed_content_rewriter` on this webpage twice with the same rewriter and it produced two copies of the output. Is there something...
It's true that `HtmlRewriter` is `!Send` and `!Sync`, yes. I'm looking into whether it's possible to remove the `Rc` around the output sink.
Oh hmm, I missed that `Settings` is also not Send or Sync, that seems especially unfortunate. I think it would be a breaking change to fix that unfortunately ... the...