jyn

Results 719 comments of jyn
trafficstars

hmm actually this is a slight expansion of scope but @bjorn3 how would you feel about not printing the giant list of linker arguments unless someone passes `--verbose` (https://github.com/rust-lang/rust/issues/109979)

also i know we settled on not showing stdout by default but it's useful for debugging search paths - maybe we should show it after all? it seems silly to...

hmm. that test has the following comment: https://github.com/rust-lang/rust/blob/e9a009fd1a9ce00ee07eeb17bc8e9985815a1296/tests/incremental/commandline-args.rs#L13-L20 i suppose those lines are all invalid now, it should be testing that the CGU is *not* reused? i'm not sure why...

this should be marked rollup=iffy; there are likely going to be warnings on other platforms that were silenced before.

lol what on earth AFAICT there are two types of warnings: 1. ``` warning: linker stderr: Warning: .drectve `-exclude-symbols:_ZN17compiler_builtins3mem6memcpy17h33c7778f71cce9faE ' unrecognized Warning: .drectve `-exclude-symbols:_ZN17compiler_builtins3mem7memmove17ha30886041cd704b7E ' unrecognized ``` 2. ``` 2024-01-30T23:15:45.4590600Z...

i am not planning to work on this more, someone else can pick it up if they care

> Oh, that's strange. In the past, Rust used `.def` files only to let the linker know which symbols to export. Maybe something has changed (likely accidentally), but we'd need...

> 1f: 61 (bad) > 25: 61 (bad) oh that doesn't look good lol ![image](https://github.com/user-attachments/assets/04a7f513-20fb-4fd2-ba3b-edf38879a045) welp http://ref.x86asm.net/coder64.html#x61

> I think this is #112368 As I understand it, LLVM emits a correct `.drectve` section with linker arguments, but the GNU linker incorrectly fails to parse the section and...