jyn

Results 724 comments of jyn
trafficstars

I don't know whether this is related at all, but I remember seeing https://github.com/rust-lang/rust/issues/13983 a while ago.

Maybe easier to implement - if bors could *show* on the queue that PR CI failed, it would at least let people know it wouldn't be included in rollups: https://github.com/rust-lang/rust/pull/84716#issuecomment-829706626

Just ran into this as well - it's very confusing, I had a PR marked as 'S-waiting-on-bors' for 6 days because I didn't know I needed to `r+` again.

Here's a recent example ([more info on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Anything.20left.20to.20complete.20this.20PR.3F)): https://github.com/rust-lang/rust/pull/79000#issuecomment-733291980 I remember one earlier that didn't have complicated commands (`r- retry`) but I can't seem to find it.

@BurntSushi you might be able to get something to work with `cargo rustdoc -- -Z unstable-options --output-format json`. I'm not intimately familiar with the JSON schema so you'll need to...

See also the ugly hack tokio uses (and the discussion about showing this in rustdoc): https://github.com/rust-lang/rfcs/pull/2963#issuecomment-669344913

~~This also has the benefit that you can perform streaming utf8-validation~~ Nope, I forgot that `String` only implements `fmt::Write`, not `io::Write`.

This isn't currently possible because there's no way to return an error from `handle_chunk`; the only thing to do is panic. @inikulin would it make sense to have that return...

My second idea is _also_ not currently possible because the compiler thinks for some reason that `Write` and `FnMut` can overlap. ``` error[E0119]: conflicting implementations of trait `transform_stream::dispatcher::OutputSink`: --> src/transform_stream/dispatcher.rs:76:1...