jyn

Results 688 comments of jyn

I tried to address @ehuss and @nikomatsakis's concerns. I renamed "label expression" to "label block expression".

I don't have objections to @pnkfelix's suggestion, but I don't know when I'll have time to apply them. Happy for someone else to push to my branch.

This also happens when returning a value from a function. ```rust pub struct Span { offset: usize, length: usize, } impl From for RangeInclusive { fn from(span: Span) -> Self...

@JohnTitor said this on the other pull request, but I'll repeat it here: > > It was written carefully. I'm certain that it's a significant improvement. > Could you elaborate...

I don't think we need to link to the debugging guide front and center on the landing page. It's easy enough to search for if people are looking for it;...

Ok, I've updated this to only say "Building rustc". I don't think we should nest links like that on the main page, there's already a *lot* of content and nesting...

I also ran into this today. Is this intentionally not supported? I'm not sure why, I'd find it useful.

@Veykril the "OnceInRoot" strategy looks like exactly what we want :) I'd love to see this merged, is there any way I can help out? Maybe test this locally on...

> Testing it would be great as well though (I don't really know the workspace setup in rustc to reliable know how to check this right now). In theory to...

> Not sure how much sense that makes but it could work. I am just not sure if `x.py` really re-emits diagnostics properly. It should. We run cargo under the...