James Cor

Results 60 issues of James Cor

We're missing support for this syntax ```sql CREATE TABLE xy (x INT, y INT); INSERT INTO xy (VALUES ROW(1, 1)); -- syntax error ``` Other variations that should work ```sql...

enhancement
sql
correctness

TODO: datetimes are now broken... This PR aims to: - simplify the logic surrounding how we handle type conversions in Arithmetic nodes - `sql.Type.Convert()` should be able to convert to/from...

collations appear to not be implemented for in-memory tables (at least for filter queries on string columns), skipped test here https://github.com/dolthub/go-mysql-server/pull/1412/files#diff-e582a7e32828ab26c283d363510802a964267ec96598d49855b66c05f10149d5R11009-R11167

This PR consolidates the logic to validate if an index. Additionally, it fixes a bug where `create table t (i int, index (i, i));` was allowed. fixes: https://github.com/dolthub/dolt/issues/6064

This PR makes dolt aware of database collation changes. We treat database collation changes similarly to a collation change to a table. To properly show a `dolt diff` we need...

correctness_approved

Before, we used to print tabular output for `dolt diff --stat -r sql`. Now, we just throw an unsupported error. There's a skipped bats test in `sql-diff.bats` Repro: ```shell dolt...

good first issue
cli
good repro

Currently, the portion of code that determines if an inputted number is parsed as a Float or Decimal expression relies on string comparisons. Additionally, the decisions that the parser makes...

enhancement
analyzer

Including a call statement inside of a trigger causes inserts (and probably other queries) to do nothing. There's a skipped tests for this here: https://github.com/dolthub/dolt/pull/7734/files#diff-0f403f04aebada5ed7b3bf9f153a5fc0d26a9535583a90ba37e13c87724501beR271 However, the repro below actually...

bug
sql
correctness

A skipped tests is added here: https://github.com/dolthub/go-mysql-server/pull/2423 ```sql prepare stmt from 'select ?'; set @a = cast(123.45 as decimal(5,2)); execute stmt using @a; ``` Related issue: https://github.com/dolthub/dolt/issues/7665

bug
sql
prepared statements

We should be able to show the database create statement as of a certain commit. Related: https://github.com/dolthub/dolt/pull/7823

enhancement
version control