dolt icon indicating copy to clipboard operation
dolt copied to clipboard

Published 20 hours ago • verified publisher icon dolthub

Hacky Float/Decimal Implementation

Open jycor opened this issue 1 year ago • 2 comments

Currently, the portion of code that determines if an inputted number is parsed as a Float or Decimal expression relies on string comparisons. Additionally, the decisions that the parser makes at this stage affects the output type, which maybe shouldn't be the case.

A less hacky implementation of that section of is here: https://github.com/dolthub/go-mysql-server/pull/1876 However, this fails a bunch of test, bringing up several (different) issues with matching the expected types MySQL returns.

jycor avatar Jul 18 '23 17:07 jycor

related:

  • https://github.com/dolthub/go-mysql-server/pull/1875
  • https://github.com/dolthub/go-mysql-server/pull/1874

max-hoffman avatar Jul 18 '23 17:07 max-hoffman

@jycor How are we feeling about this? Can we make more specific statements about certain queries that fail related to this?

max-hoffman avatar Apr 16 '24 00:04 max-hoffman