dolt icon indicating copy to clipboard operation
dolt copied to clipboard

handle database charset/collation changes

Open jycor opened this issue 1 year ago • 4 comments

This PR makes dolt aware of database collation changes. We treat database collation changes similarly to a collation change to a table.

To properly show a dolt diff we need to add support for show create database as of ..., which would require changes to vitess and gms. For now, we just show the new create statement. Addtionally, we should add support to resolve database collation merge conflicts.

Affected functions are:

  • dolt add
  • dolt commit
  • dolt status
  • dolt diff
  • dolt merge

Addresses: https://github.com/dolthub/dolt/issues/7815

jycor avatar May 06 '24 18:05 jycor

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
5ab38a2 ok 5937457
version total_tests
5ab38a2 5937457
correctness_percentage
100.0

coffeegoddd avatar May 08 '24 22:05 coffeegoddd

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d189e94 ok 5937457
version total_tests
d189e94 5937457
correctness_percentage
100.0

coffeegoddd avatar May 09 '24 00:05 coffeegoddd

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
31da11c ok 5937457
version total_tests
31da11c 5937457
correctness_percentage
100.0

coffeegoddd avatar May 09 '24 00:05 coffeegoddd

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
299cb55 ok 5937457
version total_tests
299cb55 5937457
correctness_percentage
100.0

coffeegoddd avatar May 09 '24 22:05 coffeegoddd

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
c2e5c0d ok 5937457
version total_tests
c2e5c0d 5937457
correctness_percentage
100.0

coffeegoddd avatar May 10 '24 07:05 coffeegoddd

@jycor DOLT

comparing_percentages
100.000000 to 100.000000
version result total
d6577bc ok 5937457
version total_tests
d6577bc 5937457
correctness_percentage
100.0

coffeegoddd avatar May 10 '24 19:05 coffeegoddd

@coffeegoddd DOLT

comparing_percentages
100.000000 to 100.000000
version result total
9838757 ok 5937457
version total_tests
9838757 5937457
correctness_percentage
100.0

coffeegoddd avatar May 10 '24 19:05 coffeegoddd