Juan Cruz Viotti
Juan Cruz Viotti
@Slapbox The PR I sent you seems to make the module work fine with `contextIsolation`. I tested this out on a `BrowserWindow` with: ```js nodeIntegration: false, contextIsolation: true, enableRemoteModule: false,...
I guess that what we can do is detect if `electron.contextBridge` is defined, and if so run: ```js contextBridge.exposeInMainWorld('storage', require('electron-json-storage')) ```
However keep in mind that I believe this does need to be done from within the preload script. So we would have to update the README to tell people to...
I published v4.4.0 with the latest fix
@Slapbox > On the topic of what should be in the README, I think that we should mention best practices are to expose as little of the module as you...
Hey there, thanks a lot for the contribution! Some comments: - Can we add tests for this new function? - Since this is a synchronous function, it shouldn't take a...
Can you better explain what you observed? `.getAll()` doesn't use any lock mechanism (see https://github.com/electron-userland/electron-json-storage/blob/master/lib/storage.js#L210). The only function that performs locking is `.set()` (see https://github.com/electron-userland/electron-json-storage/blob/master/lib/storage.js#L272), but the lock is released...
Hey there! This would be awesome, happy to take a PR for this feature! I really have little time to spare, at least this week, but don't hesitate in pinging...
I believe the rename operations are due the atomic write features, but there must be an underlying issue with Windows that prevents them from happening. How reliably can you reproduce...
@Xsaven Can you provide a runnable example that I can use to reproduce? Based on what I can see, though, you shouldn't be running an async function (like `storage.set`) in...