electron-json-storage icon indicating copy to clipboard operation
electron-json-storage copied to clipboard

add setSync function, write user data sync.

Open zhenshuaiwws opened this issue 8 years ago • 1 comments

When I want to save data before the app exits, but the set method does not complete before the end of the process, resulting in the data not saved successfully, so I need to save the data synchronously.

zhenshuaiwws avatar May 15 '17 06:05 zhenshuaiwws

Hey there, thanks a lot for the contribution! Some comments:

  • Can we add tests for this new function?
  • Since this is a synchronous function, it shouldn't take a callback, but simply return the value

jviotti avatar May 16 '17 15:05 jviotti