Juan Cruz Viotti
Juan Cruz Viotti
Sorry for taking so long. The overall approach looks good, but the tests seem to be failing.
Hi @philippefutureboy, thanks for the nice words! I'm definitely open to a PR that adds the sync functions. Do you think there is a way we can provide both without...
@philippefutureboy > I was thinking to rehaul the entire library to use fs-extra and Promises. Would that be something you'd be interested in? I'd prefer keeping the list of dependencies...
We're not dealing with objects that require deep merging, right? (the ones in the example above are one level, so `Object.assign` should work). Regarding `fs-extra`, what particular functions from that...
@philippefutureboy I see what you mean now. Yeah, lets give it a shot, and see how the result looks like. If the amount of code is reduced, then that's a...
Hey @MarlonCopeland , That's very weird! What OS are you running this on? Do you have a small reproducible example I can try from my side? This module uses `fs`...
Hi @Unknown025 , That sounds pretty strange. We have many tests that cover similar scenarios (https://github.com/electron-userland/electron-json-storage/blob/master/tests/storage.spec.js) and most `electron-json-storage` users perform very similar workflows. What operating system are you running...
> I tried running outside of React, during the initialization of the application, and have confirmed that electron-json-storage works perfectly fine, so looks like I'll have to figure out how...
Thanks @garasubo! The PRs look good, but Travis CI is not kicking-in for this repo for some reason. I'll see if I can make it work. I don't have admin...
See https://github.com/electron-userland/welcome/issues/13