Juan Cruz Viotti
Juan Cruz Viotti
Hm, it might make sense to vendor `lockfile` through https://github.com/jviotti/vendorpull. I'll send a PR to do this, and then we can try to land a `lockfile` patch
OK, I vendored the module here: https://github.com/electron-userland/electron-json-storage/pull/187. What is the patch you need on `lockfile`? Are you trying to retry `fs.statSync`? Given that you can reproduce the problem, if you...
Closing stale issues
Closing stale issues
Closing stale issues
@probonopd We're very interested in having AppImage updates for Etcher, and glad to hear our current approach matches what you think AppImages should be doing. Is there anything I can...
The tip of master fails at this inline assembly point: ``` In file included from /Users/jviotti/Projects/playground/Sourcetrail/src/test/test_main.cpp:3: /Users/jviotti/Projects/playground/Sourcetrail/src/external/catch/catch.hpp:5767:13: error: unrecognized instruction mnemonic, did you mean: bit, cnt, hint, ins, not? CATCH_BREAK_INTO_DEBUGGER();...
Looks like this was already fixed by Catch2 upstream: https://github.com/catchorg/Catch2/commit/a25c1a24af8bffd35727a888a307ff0280cf9387
Not sure how the project is managing its vendored dependencies, but the build works with this patch: ```diff diff --git a/src/external/catch/catch.hpp b/src/external/catch/catch.hpp index 099119d4..7eece27d 100644 --- a/src/external/catch/catch.hpp +++ b/src/external/catch/catch.hpp @@...
Closing stale PRs...