Justin Salamon
Justin Salamon
To avoid conflicts with nussl and conflicts in general.
As noted in [this PR comment](https://github.com/justinsalamon/scaper/pull/132#pullrequestreview-496952590), generate and generate_from_jams both contain large code blocks for saving metadata in the jams annotation. The code should be factored out and re-used by...
This data is now stored, along with all generation data, in `ann.sandbox.scaper.generate`. Keeping these in for now to avoid crashing e.g. FUSS, but eventually we should issue a deprecation warning...
Right now whenever we write a jams file to disk the orderOf the itemsIn the file is random, which makes it difficult to inspect changes e.g. for regression jams files....
"master" isn't an inclusive term (cf. https://www.zdnet.com/article/github-to-replace-master-with-main-starting-next-month/#:~:text=Starting%20next%20month%2C%20all%20new,them%20with%20more%20inclusive%20terms.) By the end of the year making this move should be easy, hopefully: https://github.com/github/renaming
In memory return API was added via #121, but only for `generate()` and `generate_from_jams()`, and not for `trim()`. We should add it for `trim`, and update the unit tests for:...
nuff said.
The current Scaper logo is a quick hack I put together in a rush. It would be cool to have a well-designed logo.
Raised by @turpaultn Currently using a BG sound shorter than the soundscape (which should get tiled) raises the following warning which isn't very helpful: ``` /anaconda3/envs/pytorch/lib/python3.6/site-packages/scaper/core.py:1433: ScaperWarning: freesound source time...
Need to create documentation entries/examples for: - [ ] `scaper.trim()` - [ ] `scaper.generate_from_jams()` - [ ] metadata: `n_events`, `polyphony_max` and `polyphony_gini` - [ ] synthesis parameters: `reverb`, `fade_in_len`, `fade_out_len`,...