Justin McCandless

Results 206 comments of Justin McCandless

+1 to everything that @kaiceyd said, but @matthew-carroll I wanted to jump in and say that we should all probably keep an eye on this repo, super_editor, and the framework...

Thanks, I wasn't very aware of those, will check them out.

@yasinarik I haven't built anything into InteractiveViewer to handle rendering on-demand, unfortunately. So I would guess that switching to InteractiveViewer wouldn't give you any performance benefit. Are you hoping for...

I created a separate issue as a feature request for something like InteractiveViewer.builder: https://github.com/flutter/flutter/issues/58603

My work on rotation is in this branch: https://github.com/justinmc/flutter/tree/iv-rotation It works, but it has some complex interactions with the boundary that I still need to make sure I get 100%...

@doppio Unfortunately it's probably not likely for the next stable release (9/7 cutoff). Thanks for the comment though, this gives me some more motivation to get it done. I'll make...

@hacker1024 You mentioned wanting a rotation gesture for MacOS and iPadOS in https://github.com/flutter/flutter/issues/64210#issuecomment-770202096. Do you have an opinion of what that would be? Maybe like option + scroll or something?

@liu1013269528 I had this working in https://github.com/flutter/flutter/pull/73358, but I wasn't happy with the code so I closed it for now. I hope to have time to come back to it.

I had a PR linked above but I didn't have time to get it through code review: https://github.com/flutter/flutter/pull/73358

Closing as this has been worked around in https://github.com/flutter/flutter/pull/146669 and should not require a revert.