Justin Hynes

Results 17 comments of Justin Hynes

I spent some time trying to fix this issue but couldn't resolve the issue in a reasonably short amount of time. There is some additional investigation that may be required...

Opened https://openedx.atlassian.net/browse/MICROBA-1125 to try and schedule this upgrade, noting that it may be blocked by MICROBA-874 (as Christie pointed out).

Error in the logs is... ``` Error: Module build failed (from ./node_modules/sass-loader/dist/cjs.js): SassError: Function rgb is missing argument $green. on line 2 of node_modules/@edx/paragon/scss/core/core.scss from line 7 of credentials/static/sass/_lib.scss from...

According to the [release docs](https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0), `jasmine-core` doesn't support Python in the 4.x release. We should upgrade to the [jasmine-browser-runner](https://github.com/jasmine/jasmine-browser) package.

Hi @DmytroAlipov, I was just taking a look at these changes this morning and it's a good catch. Are there any tests that can be added or updated?

OK! Thanks for the heads up. I'm not very familiar (personally) with the test suites around this functionality, I'll try take a look this morning. Worst case, we toss a...

I noticed there was a branch in Credentials to add Python 3.11 and 3.12 support, but it doesn't look ready for consumption yet. The branch is still in `draft` status...

Hi @qasimgulzar, This particular bit of code lies outside of Aperture's ownership/maintenance load, nor does the team have any experience or knowledge of the functionality in the `course_api` app. I'm...

Hi there -- just mentioning that this is on our radar too for review. I should be able to take a look shortly.

I took a look at the changes on the `master` branch and they look good, I do have an open question on the other branches PR though. I'll keep the...