edx-platform icon indicating copy to clipboard operation
edx-platform copied to clipboard

fix: course progress url based on whether the user has learning MFE enabled (for master)

Open FatemeKhodayari opened this issue 11 months ago • 5 comments

Currently, as we have in Quince, when a user hasn't passed the course, the "View Grades" link / button is displayed to him on the dashboard. Clicking on this link / button, takes the user to the old progress page. The URL of the old progress page is returned in the /api/learner_home/init response. In this change, course progress URL is returned based on whether the user has learning MFE enabled or not.

This issue was originally created in this forum topic and later discussed a little bit in the Maintenance WG meeting.

Closes https://github.com/openedx/edx-platform/issues/34323

FatemeKhodayari avatar Mar 09 '24 09:03 FatemeKhodayari

Thanks for the pull request, @FatemeKhodayari! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks avatar Mar 09 '24 09:03 openedx-webhooks

Hi there -- just mentioning that this is on our radar too for review. I should be able to take a look shortly.

justinhynes avatar Mar 26 '24 17:03 justinhynes

@FatemeKhodayari changes look good to me, can you add a test case to validate the change also, then I think this looks good to merge.

Sure! I'll try to add the test by Saturday.

FatemeKhodayari avatar Mar 27 '24 08:03 FatemeKhodayari

Hi @feanil! Just added the test. Please let me know if anything needs changing.

FatemeKhodayari avatar Mar 30 '24 13:03 FatemeKhodayari

Hi @feanil. Could you please have a look at this when possible? I last updated this repo about 3 week ago. Thanks in advance :)

FatemeKhodayari avatar May 08 '24 07:05 FatemeKhodayari

Looks great, I'll coordinate merging this tomorrow.

feanil avatar Jul 15 '24 21:07 feanil

@FatemeKhodayari 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks avatar Jul 16 '24 18:07 openedx-webhooks

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

edx-pipeline-bot avatar Jul 16 '24 20:07 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Jul 17 '24 14:07 edx-pipeline-bot

2U Release Notice: This PR has been deployed to the edX production environment.

edx-pipeline-bot avatar Jul 17 '24 14:07 edx-pipeline-bot