edx-platform
edx-platform copied to clipboard
openedx
fix: "Course Number Display String" option doesn't influence certificate for Quince
This is a backport from the master.
Description
In Advanced Settings, it is possible to redefine the name for the Course Organization as well as for the Course Number. However, a bug was discovered in replacing this name on the certificate:
For Course Number Display String everything works correctly:
But the name of the organization is always taken from the Organizations model. In this case, the definition from Advanced Settings is ignored:
For other pages, the override works correctly for both settings:
I slightly changed the logic for prioritizing the selection of the organization name for the certificate. Now everything is replaced correctly:
Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
- supporting documentation
- Open edX discussion forum threads
- timeline information ("this must be merged by XX date", and why that is)
- partner information ("this is a course on edx.org")
- any other information that can help Product understand the context for the PR
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
I took a look at the changes on the master branch and they look good, I do have an open question on the other branches PR though. I'll keep the focus of the conversation on the other PR, just commenting to let you know this PR is on my radar too.
@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.