Justin Gordon
Justin Gordon
I'm definitely seeing the issue. I work around it by manually writing screenshots which is not ideal.
You can make a PR to try allowing for another option here: https://github.com/shakacode/react_on_rails/blob/master/node_package/src/clientStartup.ts#L171 ```ts if (isServerRenderResult(reactElementOrRouterResult)) { throw new Error(`\ You returned a server side type of react-router error: ${JSON.stringify(reactElementOrRouterResult)}...
Once this feature is non-experimental, I plan to support this. @ziploker and others, PRs welcome!
@alexeyr-ci1, @tomdracz should I push a release?
@alexeyr-ci1 should I push a new version? or wait? Please check the changelog to see if it's current.
@alexeyr-ci1 Should I push a release with React 18 support? We'll also have #1455 hopefully.
@alexeyr AWESOME work! Keep going!
@Overload119 Can you create a minimal reproduction case on Github? If so, I'll try to fix the issue. Could you add turbolinks to this simple example: https://github.com/shakacode/react_on_rails_tutorial_with_ssr_and_hmr_fast_refresh ? Note, the...
@Overload119 please check #1162 and see if it's related.
For > integrate https://github.com/shakacode/react-on-webpacker, https://www.npmjs.com/package/react-on-webpacker into spec/dummy Maybe we can consider something for Shakapacker v7?