Justin Gordon

Results 444 comments of Justin Gordon

https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/package.json#L88 uses Router v4 with React on Rails v9. Does anybody want to take a crack at a PR to update the docs on this?

@mdesantis I'm totally open to a PR. Would SSR still work with importmap-rails?

@mdesantis can you hack around with this. Ping me if you need help. https://join.slack.com/t/reactrails/shared_invite/enQtNjY3NTczMjczNzYxLTlmYjdiZmY3MTVlMzU2YWE0OWM0MzNiZDI0MzdkZGFiZTFkYTFkOGVjODBmOWEyYWQ3MzA2NGE1YWJjNmVlMGE

@mdesantis have you had a chance to look into this?

I'd love to see some sort of POC of that. And what would be the advantage, compare/contrast to using rails/webpacker? it would be great to make a PR of this...

@brandoncc React on Rails previously did not depend on webpacker. If you see changes I made to React on Rails where I required webpacker, you'd have an idea of what...

@brandoncc Please see https://discuss.rubyonrails.org/t/shipping-webpacker-v6-status/79683 and let me know your thoughts.

@Overload119 How do you know that you have have 2 instances of ReactOnRails? They get set on window, so I suspect that is not happening.

@Overload119 did you determine the cause of this issue? Maybe it's related to #1350 and Turbolinks? > This invokes ReactOnRails twice. This shouldn't be possible if you've setup your bundle...

Hi @mattclough1, any suggestion for a fix? I don't see this widely reported. Why are you doing this: https://github.com/mattclough1/react-on-rails-demo/blob/main/app/javascript/packs/hello_react.jsx#L21-L26