Justin Gordon

Results 444 comments of Justin Gordon

Does anybody know if React 18 works with the current codebase using yarn? CC: @ro-savage

Let's reopen this one if we want to support more Ruby gem bundled JS code. NPM is a better source for React. @BookOfGreg Feel free to reopen if feel we...

@HarrisonB can you rebase this on master?

@HarrisonB can you confirm that all unit tests run locally? Currently, we don't have CI working. We need to move to GH Actions.

@ynagorny This seems to be a breaking change for those that don't upgrade to React 18. Please confirm. Do you want to propose a solution that works with React 16+17...

@jcn let's think about what this would look like. Please feel free to make suggestions.

Closing because we'll need slightly different updates going forward.

@stevegeek, I'd love to brainstorm with you to better understand what the issue is. My email is on my Github profile. Or can you explain the lines in your "fragile...

> ie the bundle contains HMR logic which references window. That's because of the webpacker configuration. The SSR configuration needs to be different. Does react-rails support having different configurations for...