juj
https://github.com/emscripten-core/emscripten/pull/21555 introduced a bidirectional breaking change that Emscripten 3.1.56 doesn't allow one to declare ```js foo__deps: ['$stackSave', '$stackAlloc', '$stackRestore'] ``` but Emscripten 3.1.57 requires users must do so. So I...
> Utf8? I like the idea, it is just that doesn't utf8 takes 2 bytes for cp > 127? If I have really bad luck, the file size will be...
Looks like other tests pass, but CircleCI gets a failure in core2: ``` Call parameter type does not match function signature! %a.var = alloca ptr addrspace(10), align 1, addrspace(1) ptr...
Yeah, having an opt-out setting for a while would be good from that perspective.
> Is this working. Can I try it? Yeah, looks like the CI now passes (there were some intermittent CI failures last week), so this should be good to land.
Updated this PR to latest. Added new -sSINGLE_FILE code size test in binary encoded mode. The improvement delta from base64-encoded SINGLE_FILE to this binary-encoded SINGLE_FILE in that code size test...
CI looks good and green now. This is good for another round of review.
Closing old stale PR.
> Looks like we lost the actual fix someshow? It looks like the debug comments that have been added in main have a side-effect of applying the fix.