Juan Antonio García

Results 29 comments of Juan Antonio García

> Perhaps when we call `SetFileList` and the list is not empty, we should force `fFilesMatchingPattern = "fileList"` so that when we explore the metadata we know the file list...

> Please, share in case that you foresee another **use-case** where you will need a library for raw signal processing that it is outside `rawlib`. I think this topic is...

> Should `TRestSignalAnalysis` be renamed to something different such as `TRestTimeSignalAnalysis`, `TRestPulseShapeAnalysis` or `TRestWaveFormAnalysis`? `TRestSignal` it is quite generic and it might be used in an statistical case, such as...

@lobis and @jgalan can you approve or give me feedback in the related PR? I cannot merge otherwise. - https://github.com/rest-for-physics/rawlib/pull/100 - https://github.com/rest-for-physics/connectorslib/pull/27 - https://github.com/rest-for-physics/detectorlib/pull/75

> If I remember correctly you cannot write the implementation of the template methods separately in the cxx file, unless you `#include` this cxx file like a .h file. I...

Note that the following submodule PR needs to be merged together with this one: - https://github.com/rest-for-physics/rawlib/pull/100 - https://github.com/rest-for-physics/connectorslib/pull/27 - https://github.com/rest-for-physics/detectorlib/pull/75

I cannot reproduce the issue, while doing `make uninstall` all the libraries are properly uninstalled. Perhaps this is a corner case when you do `cmake -DRESTLIB_AXION=OFF ...` in the same...

> Yes, may be, it couldn't be that the `cmake` detects that I used `-DRESTLIB_AXION=OFF` and calls `make uninstall`? Or that whenever we invoke `cmake` the `make uninstall` is invoked?...

> I don't think we should name all the classes using `TRestDataSet` I think we should assume these classes will use internally `TRestDataSet` as something natural. > Well, I just...

> We could update the PR submodule description to indicate how to proceed. I.e. explain that a new framework PR has been created automatically. It is difficult to imagine all...