Juan Antonio García
Juan Antonio García
> We could update the PR submodule description to indicate how to proceed. I.e. explain that a new framework PR has been created automatically. This is possible but not straightforward,...
> I understand we will then have a dedicated `lml` for each submodule inside the framework? E.g. `axionlib_validation.yml` ... `restG4_validation.yml` ... that will be launched independently? In principle, this is...
> ``` > echo "branchAtRepositoryExists.sh framework ${{ env.BRANCH_NAME }}" >> $VALIDATION_BRANCH > uses: rest-for-physics/framework/.github/workflows/validation.yml@$VALIDATION_BRANCH > ``` It seems that the solution you propose is not supported by github actions, we...
> The data merging can be done at the TRestDataSet level, where the metadata of the TRestDataSet allows to univocally identify the file list used to generate the analysis dataset...
I think we decided some time ago to move to C++17, I don't understand why we should revert to previous C++ versions, C++11 is from more than 10 years ago....
> I don't think making it compatible with c++11 is moving backward. I did not revert the code. I am just adding the traditional solutions with `dirent.h` in case no...
> Any ideas/shortcut on how to capture the output I mentioned above? I think the issue is that you are not redirecting the error stream, to do it you can...
> In practice, `TRestDetectorSignal` is a transition between `TRestDetectorHits` and `TRestRawSignal`. It keeps physical times and amplitudes that will be used for event reconstruction. I can see some other functions...
> We discussed this already with @lobis at some point. It is true this fact is missing. We discussed the idea about having another vector inside `TRestRawSignal`, for example `std::vector...
@lobis and @jgalan can you approve please? I want to check if the pipeline passes after approval, also you have to approve this one https://github.com/rest-for-physics/rawlib/pull/71