Juan Antonio García

Results 14 issues of Juan Antonio García

![juanangp](https://badgen.net/badge/PR%20submitted%20by%3A/juanangp/blue) ![Ok: 23](https://badgen.net/badge/PR%20Size/Ok%3A%2023/green) [![](https://github.com/rest-for-physics/framework/actions/workflows/validation.yml/badge.svg?branch=fileListDF)](https://github.com/rest-for-physics/framework/commits/fileListDF) [](https://pullrequestbadge.com/?utm_medium=github&utm_source=rest-for-physics&utm_campaign=badge_info) Added the posibility to add a file list instead of a file pattern in TRestDataSet. Note that if the file list is empty it will...

![juanangp](https://badgen.net/badge/PR%20submitted%20by%3A/juanangp/blue) ![Ok: 31](https://badgen.net/badge/PR%20Size/Ok%3A%2031/green) [![](https://github.com/rest-for-physics/framework/actions/workflows/validation.yml/badge.svg?branch=rest_daq)](https://github.com/rest-for-physics/framework/commits/rest_daq) [](https://pullrequestbadge.com/?utm_medium=github&utm_source=rest-for-physics&utm_campaign=badge_info) - New `restDAQ` package has been added as a submodule, check https://github.com/rest-for-physics/restDAQ for more details - Minor changes on `CMakeList.txt` Related PR https://github.com/rest-for-physics/rawlib/pull/35

I found an issue merging datasets using `TRestDataSet::Import` function implemented here: https://github.com/rest-for-physics/framework/blob/9c2fae713e932c11c23efc78e332bdac2e3dad5e/source/framework/core/src/TRestDataSet.cxx#L952 Although the trees are properly merged the metadata has issues, for instance while merging two datasets the duration...

![juanangp](https://badgen.net/badge/PR%20submitted%20by%3A/juanangp/blue) ![Large: 785](https://badgen.net/badge/PR%20Size/Large%3A%20785/red) [![](https://github.com/rest-for-physics/framework/actions/workflows/validation.yml/badge.svg?branch=signal-ana)](https://github.com/rest-for-physics/framework/commits/signal-ana) [](https://pullrequestbadge.com/?utm_medium=github&utm_source=rest-for-physics&utm_campaign=badge_info) New namespace for generic signal analysis inside framework, it implements different methods: - Different methods for baseline calculation - Signal smoothing - Methods for signal...

![juanangp](https://badgen.net/badge/PR%20submitted%20by%3A/juanangp/blue) ![Large: 917](https://badgen.net/badge/PR%20Size/Large%3A%20917/red) [![](https://github.com/rest-for-physics/framework/actions/workflows/validation.yml/badge.svg?branch=tmva)](https://github.com/rest-for-physics/framework/commits/tmva) Implementing `TMVA` methods for high level analysis, please check https://root.cern.ch/download/doc/tmva/TMVAUsersGuide.pdf for further details on `TMVA`. Summary of changes: - New class `TRestDataSetTMVA` to evaluate different TMVA...

![juanangp](https://badgen.net/badge/PR%20submitted%20by%3A/juanangp/blue) ![Large: 228](https://badgen.net/badge/PR%20Size/Large%3A%20228/red) [![](https://gitlab.cern.ch/rest-for-physics/framework/badges/submodule-PR/pipeline.svg)](https://gitlab.cern.ch/rest-for-physics/framework/-/commits/submodule-PR) [![](https://github.com/rest-for-physics/framework/actions/workflows/validation.yml/badge.svg?branch=submodule-PR)](https://github.com/rest-for-physics/framework/commits/submodule-PR) Automatic submodule update and automatic merge of `submodule` PR: - Automatic update of `submodule` hash in `framework` which is triggered by a PR for the...

rawlib-pr
detectorlib-pr
geant4lib-pr
tracklib-pr
connectorslib-pr
axionlib-pr
legacylib-pr
wimplib-pr
restG4-pr

Looking at the issues on validation that we had recently, I think a new workflow for the PR is required. Here my proposal: - PR on `submodules` trigger the creation...

enhancement
policy

![juanangp](https://badgen.net/badge/PR%20submitted%20by%3A/juanangp/blue) ![Large: 337](https://badgen.net/badge/PR%20Size/Large%3A%20337/red) [![](https://gitlab.cern.ch/rest-for-physics/framework/badges/fileMerger/pipeline.svg)](https://gitlab.cern.ch/rest-for-physics/framework/-/commits/fileMerger) [![](https://github.com/rest-for-physics/framework/actions/workflows/validation.yml/badge.svg?branch=fileMerger)](https://github.com/rest-for-physics/framework/commits/fileMerger) New metadata class TRestRunMerger meant to merge different TRestRun files, merging of the files can be performed using rml config files or macros: - Merging...

Some functions seems duplicated within [TRestDetectorSignal](https://github.com/rest-for-physics/detectorlib/blob/master/inc/TRestDetectorSignal.h) and [TRestRawSignal](https://github.com/rest-for-physics/rawlib/blob/master/inc/TRestRawSignal.h), for instance `GetSignalSmoothed`, `GetBaseLine` and `GetBaseLineSigma`. I propose de following: - Implement generic methods for signal processing that should be agnostic of...

enhancement
development

![juanangp](https://badgen.net/badge/PR%20submitted%20by%3A/juanangp/blue) ![Medium: 119](https://badgen.net/badge/PR%20Size/Medium%3A%20119/orange) [![](https://gitlab.cern.ch/rest-for-physics/framework/badges/auto-merge/pipeline.svg)](https://gitlab.cern.ch/rest-for-physics/framework/-/commits/auto-merge) [![](https://github.com/rest-for-physics/framework/actions/workflows/validation.yml/badge.svg?branch=auto-merge)](https://github.com/rest-for-physics/framework/commits/auto-merge) Added new workflow for automatic merging of submodule PR when a submodule branch matches and a submodule PR exist: - Check if any submodule branch...