James Sumners

Results 658 comments of James Sumners

Please provide a minimal reproduction script.

Does this not work?: ```js const pinoDebug = await import('pino-debug') ```

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

> Any idea why the tests are failing there, has something significantly changed in pino 7? Yes. A lot. Please review the releases page https://github.com/pinojs/pino/releases

https://github.com/pinojs/pino-debug/runs/4850023188?check_suite_focus=true#step:6:95 is at least one test that needs to be revised.

Typically, we put them under https://github.com/pinojs/pino-debug/releases. But I see that we have not been maintaining that for this repository. https://github.com/pinojs/pino-debug/commits/master serves as changlog, though.

Best guess is it's a vestige of the original implementation.

That's the point of https://github.com/pinojs/pino-http/blob/9109d5446a9c2cc02ba5b98f3bd345d9c24db61a/logger.js#L80-L88 -- so the user can supply the logger their application was already using. I am typically instantiating my logger before I get around to setting...