pino-debug icon indicating copy to clipboard operation
pino-debug copied to clipboard

Update tap to v15

Open jonathansamines opened this issue 3 years ago • 3 comments

Updated project to tap 15. Most of changes are due to deprecations:

  • Several aliases are now deprecated (i.e t.is, t.throw)
  • --esm option was removed. Using causes the failures seen in #73
  • afterEach no longer supports callbacks

Notes

--coverage=true currently causes some tests to fail. ~~Seems to be related to https://github.com/tapjs/node-tap/issues/669, but I am still investigating~~. When coverage is enabled, tests that use execSync to verify the log redirection to pino fail because it doesn't happen (debug logs are redirected to stderr instead)

Edit 2

The problem seems to come from the nyc upgrade from v14 to v15:

# fails in tap 15 (nyc 15), but succeeds in tap 14 (nyc 14)
npx tap test/*.js

# fails with nyc 15 but succeeds in nyc 14
npx nyc tap --no-coverage test/*.js

jonathansamines avatar Dec 29 '21 21:12 jonathansamines

Codecov Report

Merging #83 (231198a) into master (a093832) will increase coverage by 2.00%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #83      +/-   ##
===========================================
+ Coverage   98.00%   100.00%   +2.00%     
===========================================
  Files           2         2              
  Lines          50        50              
===========================================
+ Hits           49        50       +1     
+ Misses          1         0       -1     
Impacted Files Coverage Δ
index.js 100.00% <0.00%> (+2.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a093832...231198a. Read the comment docs.

codecov-commenter avatar Jan 18 '22 03:01 codecov-commenter

https://github.com/pinojs/pino-debug/runs/4850023188?check_suite_focus=true#step:6:95 is at least one test that needs to be revised.

jsumners avatar Jan 18 '22 14:01 jsumners

can you fix CI? It seems it does not work anymore with debug@4

mcollina avatar Jan 18 '22 15:01 mcollina