pino-pretty icon indicating copy to clipboard operation
pino-pretty copied to clipboard

can we rename `outputStream` to `destination` to match pino v5 parlance

Open davidmarkclements opened this issue 5 years ago • 3 comments

Due to the addition of pino.destination, and that fact SonicBoom kind of is and kind of isn't a stream, the adoption of the term "destination" has become prevalent in the v5 documentation.

For parity with pino, in the next-major branch, are there any arguments against renaming outputStream option to destination.

davidmarkclements avatar Jul 14 '18 15:07 davidmarkclements

oh hold on a second it looks like the outputStream default option isn't used at all

@jsumners can you clarify?

davidmarkclements avatar Jul 14 '18 15:07 davidmarkclements

+1 on using destination.

mcollina avatar Jul 15 '18 12:07 mcollina

Best guess is it's a vestige of the original implementation.

jsumners avatar Jul 15 '18 17:07 jsumners