Results 163 comments of jrhee17

Micrometer already provides bindings to Netty Metrics (ref: https://docs.micrometer.io/micrometer/reference/reference/netty.html) I prefer that we either: 1) We close this issue and allow users to add metric bindings themselves. Adding the metric...

Hi, there's actually a `ObservationConvention` defined for Armeria [DefaultServiceObservationConvention](https://github.com/line/armeria/blob/main/core/src/main/java/com/linecorp/armeria/server/observation/DefaultServiceObservationConvention.java) which can be enabled via [ObservationService](https://github.com/line/armeria/blob/main/core/src/main/java/com/linecorp/armeria/server/observation/ObservationService.java). Having said this, let me look into why Spring's integration doesn't work for Armeria in...

I found a bug in armeria's implementation which doesn't return the correct status code - I'll try to get this merged in the next milestone 🙏

As a follow-up, I think running decorators from virtual threads would also be useful and a widely sought feature. We may also want to consider either 1) Finding a way...

Hey thanks, we're definitely discussing designs on this at the moment. > Does having virtual threads mean better performance for blocking tasks? Especially for blocking task executor? Currently, `blockingTaskExecutor` only...

Hi, thanks for asking. > Do you think we should fix this with a layout engine or should we track this issue separately and have a quick fix? I'm guessing...

Can you also sign the CLA? https://github.com/line/armeria/pull/5895#issuecomment-2335185610

Did a local check, and it seems like the delegate method cannot be found for some reason: ![스크린샷 2024-10-14 오후 6 44 01](https://github.com/user-attachments/assets/8362bafa-a5c7-465a-947b-bee59d52dae1)

I realized `delegateMH` doesn't work as expected 😅 We'll fix this from armeria-side in the next version 🙏