Adrien Grand

Results 310 comments of Adrien Grand

Have you seen interesting performance numbers with this change?

I agree that the penalty feels too high. We have challenges with queries like this one because there is no good theoretical basis for the right way to score such...

Thanks for looking at this! > This can be changed to first collect all the matching documents and then perform prefetch of the blocks for matched documents followed by actual...

> Am I correct in understanding that prefetching an already-fetched page is (at least approximately) a no-op? We tried to make it cheap (see e.g. the logic to disable calling...

> If I understand correctly, the read ahead mechanism in IndexInput will be useful if matching docs fall within the read ahead size. Otherwise those will be wasted pages cached...

@sohami I gave a try at a possible approach at #13450 in case you're curious.

> Then before evaluating if these docs matches TwoPhaseIterator or not, we can perform prefetch on these buffered docs (via some prepareMatches mechanism on TwoPhaseIterator). This can be done, but...

The ability to configure Lucene file formats by adding tuning knobs has come up a few times in the past and the answer has been to create a custom codec,...

I'm not sure I like this idea, which feels quite arbitrary: why would there be a big gap of matching doc IDs towards the start of the doc ID space,...

@Deepika0510 You don't only need to wrap the IndexReader, you also need to wrap all its leaves.