Adrien Grand
Adrien Grand
Thanks @vsop-479. Do you know if the test you added to terms can be improved in such a way that it would have caught this bug?
Thanks for looking into a test for this. @mikemccand Would you have time to have a look at this? I knew it was complex, but even more than I had...
@mikemccand I could use your help to review this change, it's quite deep in the guts of block tree.
Would we be subject to the same issue if/when 3+ different implementations of `DocIdSetIterator` get used in `IntersectVisitor#visit`?
Relatedly indeed, I was wondering if the API should expose an IntsRef or something like that, so that there is a single virtual call per block of doc IDs anyway...
++ on progress over perfection That said, I wonder if this change is legal: `DocIdSetIterator` must return doc IDs in order, but it looks like it wouldn't always be the...
> I will try adding a visit() method taking an IntsRef (I believe that is what you meant @jpountz?). This is what I meant indeed. Before merging I'd be curious...
It looks like this PR is in a bad state somehow?
I'm curious what problem you are trying to address. It looks like you're trying to avoid the overhead of checking the number of clauses, but intuitively this wouldn't help much...
`IntersectsTermsEnum` is a bit scary to me, maybe @mikemccand can take a look, I expect him to be more familiar with it.