Julianus Pfeuffer

Results 1002 comments of Julianus Pfeuffer

Good ideas. The problem with the last approach is that it is very costly with our current data structures. I think we would need a binned and indexed representation of...

Not saying it can't be done. @timosachsenberg and me were just thinking about potentially faster or easier to implement ways

First batch of general comments: Arrow does not necessarily need to be in contrib. You could just install it from vcpkg or conda. But even if you put it in...

I don't really understand if the json explicit conversion is working now or not? You have changes here that apparently pass on Linux. So what's working and what is not?

I get it now. The reason why you saw the errors on Linux is most likely that your CMake setting had no effect on the already built external json lib....

Hi! So, **if** we go the contrib way (remember there might be other ways to get arrow on Win), arrow should be built with as few optional dependencies as possible....

Conda or vcpkg will be the thing that installs/builds the dependencies. You just point OpenMS' Cmake to where they install the libs and our CMake should pick them up. The...

For vcpkg you could also enable binary caching and like we do for contrib and just publish to GH packages. Then register this as a source: https://learn.microsoft.com/en-us/vcpkg/consume/binary-caching-github-packages?pivots=windows-runner

Can someone write a high-level description on how this PR handles indexedMzML gzipped? Is there a standard for it? Do you write the index offsets plain text? If not, how...

Cool addition in any case.