Julianus Pfeuffer
Julianus Pfeuffer
Nice work. I think some schema definition files were definitely needed. I am wondering if we could additionally support json-schema since it is a common default for some tools like...
And why no pandera yet? Overkill? Because I think they support writing/parsing schemata.
AI comments all look reasonable, please check them. Other than that, a quick manual scan looks good. I am sure it's better than before.
@ypriverol I think until we support passing through multiple enzymes, the SDRF parser should combine the enzymes from the SDRF, print a warning and pass only Trypsin to downstream tools....
I totally support this endeavour. I would love to be able to more easily adapt validators based on downstream applications. E.g. validating an SDRF for converting to a certain downstream...
Hi! AFAIK This is currently not exposed to python. You need to iterate over the ConsensusMap and get the information from the feature handles.
I guess what I am asking is to allow a "validator" for certain groups of columns that interprets them as optional. I.e. *if* the instrument type column is present, validate...
Alternatively I could put NOT AVAILABLE in all rows of those columns, but I think the openms-convert functionality does not correctly handle columns with NOT AVAILABLE, since it will try...
@ypriverol @daichengxin Any thoughts on this?
OpenMS is right. There are clearly triplicates for each entry.