Jan-Philipp Benecke

Results 81 comments of Jan-Philipp Benecke

Thanks @Veratil for your extensive research on this, much appreciated! 👍

I would prefer this PR to mine (https://github.com/home-assistant/core/pull/128534) as it is less nested.

> I think it's a nice change and now that I'm seeing how much we log on info, it'll probably clean up a lot of logs for a lot of...

Well, removing things depends on someone removing them from the code 🙂 Since no one has done that and I haven't had time in the last few weeks, it's still...

Thanks for bringing this up 👍 This is a unfortunately frontend issue and there is already a issue for this https://github.com/home-assistant/frontend/issues/21984. This is how the frontend currently handles duration sensors....

> may I ask why the old attributes were made diagnostic sensors? Every update (that's every ping cycle) has caused a state update on the state machine and not every...

> So I guess this will be fixed in future release? When someone proposes a fix for it, yes. Again this is a issue within the frontend (home-assistant/frontend#21984), which not...

Thanks for the review. I moved the "resolving" of `` to the UDP handle and added a test case for `getaddrinfo`

I'm more than happy to go down the prettier route, considering that `jsbeautifier-go` isn't maintained since a long time. We just need to think about how we handle the prettier...

> Should this be ctrl/cmd + N? That would conflict with (at least) Chrome on macOS, they use cmd + N for a new tab.