Jan-Philipp Benecke

Results 81 comments of Jan-Philipp Benecke

What do you say about that ? ![image](https://user-images.githubusercontent.com/3989428/80291509-4a2ec780-874e-11ea-8597-be334cb48db4.png)

Sure. Created the [PR 84](https://github.com/maputnik/osm-liberty/pull/84)

PDNS also failed on several integration tests. This has been fixed with #1569.

The parser function of `namedotcom` would also work for `powerdns`. All integration tests and unit tests are passed with it.

I've successfully rerun the integration tests with `decode.QuoteEscapedFields` for POWERDNS. Should I create a PR merging into your branch?

> 2\. I noticed you use `ctx.Log.Printf` instead of `printer.Printf` (for example). While I realize that global variables are usually considered bad, but `printer.` has the benefit that it can...

> I'm super excited that you're working on this. I think concurrency is going to be a huge improvement! You're welcome, unfortunately it took me a little longer to do...

Perfect :) I already started something, it is now a GH app so the username, who comments the PR, is not "github-actions". I need to clean up the code a...

Would look like this ![image](https://user-images.githubusercontent.com/3989428/100245915-da2d2d80-2f38-11eb-93bf-1058c6d4914d.png)

Code is at [https://github.com/jpbede/codeowners-mention](https://github.com/jpbede/codeowners-mention) and app at [https://github.com/apps/codeowners-mention](https://github.com/apps/codeowners-mention)