Jan-Philipp Benecke

Results 81 comments of Jan-Philipp Benecke

Hm that would reduce the duplication of strings yes, but the entity names from System Monitor slightly differ from yours. System Monitor appends something to then name: ``` self._attr_name: str...

Talked about that with an other member, integrations should not reference to other strings from other integrations

I guess that would be a good idea as you plan to add more sensors. Depending on the system Webmin is running on, that could be a lot.

> Right now I use a windows script to monitor my computers. It monitors about 200 computers with a ping interval of 45 minutes. I was thinking of removing this...

This seems more or less a permissions issue with the Docker container. I've tried to reproduce this in my development environment (which is running as a non-root user). The integration...

Try to set up https://www.home-assistant.io/integrations/shell_command/ and check if you can start `ping` from there. If this doesn't work either, it has something to do with Podman and the container image.

Hmm the PR still not gets labeled.

Thanks @joostlek 👍

Converted to draft again, need to clean up the tests first

Thanks for your review @gjohansson-ST