dnscontrol icon indicating copy to clipboard operation
dnscontrol copied to clipboard

Auto-Mention provider code owner

Open jpbede opened this issue 4 years ago • 22 comments

I'm currently thinking about a GH action, which parses the CODEOWNERS file and mentions the user automatically when a PR is created which for he/she is a owner. This is something GH already has but it requires write-access for the code owners to the repo. With a GH action this is not necessary.

I think this would enhance your workflow @tlimoncelli :)

If you like the idea, i would figure this out and create a action

jpbede avatar Nov 24 '20 19:11 jpbede

That would be great and would save me time for sure.

CC: @MaxHorstmann

tlimoncelli avatar Nov 25 '20 14:11 tlimoncelli

Agreed, great idea @jpbede! I'd be happy to work with you on that.

MaxHorstmann avatar Nov 25 '20 14:11 MaxHorstmann

Perfect :) I already started something, it is now a GH app so the username, who comments the PR, is not "github-actions". I need to clean up the code a bit and then i can release it.

jpbede avatar Nov 25 '20 14:11 jpbede

Would look like this

image

jpbede avatar Nov 25 '20 15:11 jpbede

Sure, that's fine! 👍 Could also request a review from that person.

MaxHorstmann avatar Nov 25 '20 16:11 MaxHorstmann

@jpbede thanks for working on this!

GitHub might have just built the same feature - check this out:

image

MaxHorstmann avatar Dec 08 '20 18:12 MaxHorstmann

Yea as far as i understood, this only works when the user, mentioned in CODEOWNERS, also has write access to the repository. I may missunderstood this also.

jpbede avatar Dec 08 '20 18:12 jpbede