Joyee Cheung
Joyee Cheung
I think we can just mark SEA on x64 + macOS as "unsupported" if no one ends up fixing it.
I think this may be a different one, the other one is a race when require and dynamic import happens at the same time, and the fix would be making...
FYI I think I figured out what is causing this - fix in https://github.com/nodejs/node/pull/57187 which locally make https://github.com/fisker/prettier-plugin-blade-311 produce ``` [error] No parser could be inferred for file "/Users/joyee/projects/prettier-plugin-blade-311/fixture.blade.php". ```...
Maybe we should create a new repo for this? And we PR the evaluation as documents that can be easily looked up by posterity? (or reuse next-10 repo?)
Hmm, looks like we just need to skip the SEA stuff for worker threads during bootstrap, since that's meant for the main thread anyway.
I feel that it might need some clarifications about what this util is targeting 1. If this is for checking "whether the string will hit an internal fast path", then...
I see, in that case it should probably be placed as something like `v8.isOneByteRepresentation()`, as this is very V8-specific, although note that this can start to backfire if V8 changes...
Returning byte length + encoding SGTM (although I think the one for two-byte should be utf16, and for V8 the endianness is the same as the one from the platform...
```diff diff --git a/deps/v8/src/snapshot/serializer.cc b/deps/v8/src/snapshot/serializer.cc index f4cc04b6f4..ae2bd8f256 100644 --- a/deps/v8/src/snapshot/serializer.cc +++ b/deps/v8/src/snapshot/serializer.cc @@ -1150,10 +1150,13 @@ void Serializer::ObjectSerializer::VisitExternalPointer( Tagged host, ExternalPointerSlot slot) { PtrComprCageBase cage_base(isolate()); InstanceType instance_type = object_->map(cage_base)->instance_type(); +...