node icon indicating copy to clipboard operation
node copied to clipboard

src: support WeakReference, diagnostics_channel and net in the snapshot

Open joyeecheung opened this issue 1 year ago • 2 comments

The first commit comes from 44192.

The support for net isn't complete, for example there is still work to be done to make the DNS code snapshotable. But it's already alright to snapshot sockets that have never fired DNS requests and are not actively open.

Refs: https://github.com/nodejs/node/issues/44014 Refs: https://github.com/nodejs/node/issues/37476

joyeecheung avatar Aug 09 '22 18:08 joyeecheung

Review requested:

  • [ ] @nodejs/gyp
  • [ ] @nodejs/net
  • [ ] @nodejs/startup

nodejs-github-bot avatar Aug 09 '22 18:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/45955/

nodejs-github-bot avatar Aug 09 '22 18:08 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/45972/

nodejs-github-bot avatar Aug 10 '22 13:08 nodejs-github-bot

Marking this as blocked since it depends on https://github.com/nodejs/node/pull/44192. Please feel free to unmark it.

legendecas avatar Aug 10 '22 17:08 legendecas

Probably blocked on https://github.com/nodejs/node/pull/44203 too unless we want to skip the weak reference test in the debug build..

joyeecheung avatar Aug 11 '22 04:08 joyeecheung

CI: https://ci.nodejs.org/job/node-test-pull-request/46063/

nodejs-github-bot avatar Aug 18 '22 14:08 nodejs-github-bot

Rebased since https://github.com/nodejs/node/pull/44192 and https://github.com/nodejs/node/pull/44203 has landed

joyeecheung avatar Aug 18 '22 14:08 joyeecheung

Landed in dab205748dde...fddc701d3c0e

joyeecheung avatar Aug 19 '22 04:08 joyeecheung

Probably blocked on #44203 too unless we want to skip the weak reference test in the debug build..

fddc701d3c0eb4520f2af570876cc987ae6b4ba2 did not landed cleanly in current v18.x-staging branch. Given that https://github.com/nodejs/node/pull/44203 is currently marked as backport-blocked-v18.x I'll go ahead and label this one as blocked too.

ruyadorno avatar Aug 22 '22 22:08 ruyadorno

Marking this as blocked since it depends on #44192. Please feel free to unmark it.

#44192 will need to be backported so this one will remain backport-blocked for now

ruyadorno avatar Aug 23 '22 03:08 ruyadorno

Marking this as blocked since it depends on #44192. Please feel free to unmark it.

#44192 will need to be backported so this one will remain backport-blocked for now

Same thing for v16.x

juanarbol avatar Sep 30 '22 03:09 juanarbol