node
node copied to clipboard
src: support WeakReference, diagnostics_channel and net in the snapshot
The first commit comes from 44192.
The support for net isn't complete, for example there is still work to be done to make the DNS code snapshotable. But it's already alright to snapshot sockets that have never fired DNS requests and are not actively open.
Refs: https://github.com/nodejs/node/issues/44014 Refs: https://github.com/nodejs/node/issues/37476
Review requested:
- [ ] @nodejs/gyp
- [ ] @nodejs/net
- [ ] @nodejs/startup
CI: https://ci.nodejs.org/job/node-test-pull-request/45955/
CI: https://ci.nodejs.org/job/node-test-pull-request/45972/
Marking this as blocked since it depends on https://github.com/nodejs/node/pull/44192. Please feel free to unmark it.
Probably blocked on https://github.com/nodejs/node/pull/44203 too unless we want to skip the weak reference test in the debug build..
CI: https://ci.nodejs.org/job/node-test-pull-request/46063/
Rebased since https://github.com/nodejs/node/pull/44192 and https://github.com/nodejs/node/pull/44203 has landed
Landed in dab205748dde...fddc701d3c0e
Probably blocked on #44203 too unless we want to skip the weak reference test in the debug build..
fddc701d3c0eb4520f2af570876cc987ae6b4ba2 did not landed cleanly in current v18.x-staging
branch. Given that https://github.com/nodejs/node/pull/44203 is currently marked as backport-blocked-v18.x
I'll go ahead and label this one as blocked too.
Marking this as blocked since it depends on #44192. Please feel free to unmark it.
#44192 will need to be backported so this one will remain backport-blocked for now
Marking this as blocked since it depends on #44192. Please feel free to unmark it.
#44192 will need to be backported so this one will remain backport-blocked for now
Same thing for v16.x