Josh Romero

Results 125 comments of Josh Romero
trafficstars

> @joshuarrrr I already added some description of what I have done to fix the responsive and visualize it with 2 screenshots above. Is that okay? Yep, thanks, that's helpful!

Wetting this to draft - @thanhinhchtom Feel free to set it back if you're able to revisit.

I'd like a little more validation that other folks think this is a good idea/worth doing before we invest in it.

> How is this different from #1094? Is there a case we would want this older version as apposed to the newer one? It's more incremental, so there's a smaller...

> These same kind of conflicts keep appeared in my previous PR I'm curious about why this kind of conflict actually occurs? ![image](https://user-images.githubusercontent.com/52494840/283769833-6aa9be36-788c-4dd4-adfd-c393f1aaddc2.png) > > ``` > >>> main >...

@AwesomeSauce42 One of the new commits is missing the signoff. You can fix by following the instructions in https://github.com/opensearch-project/oui/pull/1080/checks?check_run_id=17733550749 Also, please add an entry to the Changlelog file, under the...

@AwesomeSauce42 Which issue is this for? The issue number in the description doesn't appear to be valid.

> > @AwesomeSauce42 One of the new commits is missing the signoff. You can fix by following the instructions in https://github.com/opensearch-project/oui/pull/1080/checks?check_run_id=17733550749 > > Also, please add an entry to the...

@AwesomeSauce42 Just checking in on the progress of this - have you had a chance to look at the feedback, or do you have other questions about the next steps?...

@Willie-The-Lord Thanks so much for your patience and persistence here. I'm a little torn about approving this and merging as is (because I do believe it fixes https://github.com/opensearch-project/oui/issues/1068), or continuing...