Josh Romero

Results 125 comments of Josh Romero
trafficstars

@ShatilKhan Can you take a look at resolving the conflicts?

@ShatilKhan Just checking back on this PR. Do you have any questions about how to resolve the conflicts? I'll mark it as a draft for now until you have time...

@keskami For UI changes like this can you provide some screencasts or screenshots of the before and after behavior of the component? That makes it much quicker for reviewers to...

@NishantSinghal19 Just checking in to see if you'll be able to make the last couple changes requested.

@BSFishy Can we close this, or are there still action items here?

Cool, so we'll use OuiBasicTable as a guide for updating the header behavior in OuiDataGrid

@keskami I have a feeling you may have other questions as you start to investigate how to update this. Feel free to ask them here.

@keskami It looks like there's already a draft PR for it: https://github.com/opensearch-project/oui/pull/755

Setting to draft in favor of https://github.com/opensearch-project/oui/pull/1102

Currently present in 73! files. I think this is something we can work on incrementally, as there is some risk to attempting to fix these.