oui
oui copied to clipboard
opensearch-project
New file utils.js, moved teardown function
Description
Added a utils file and moved the euiBuildTimeAliasTearDown function to it.
Issues Resolved
Works on issue #1061
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
@AwesomeSauce42 One of the new commits is missing the signoff. You can fix by following the instructions in https://github.com/opensearch-project/oui/pull/1080/checks?check_run_id=17733550749
Also, please add an entry to the Changlelog file, under the "Infrastructure" section.
@AwesomeSauce42 One of the new commits is missing the signoff. You can fix by following the instructions in https://github.com/opensearch-project/oui/pull/1080/checks?check_run_id=17733550749
Also, please add an entry to the Changlelog file, under the "Infrastructure" section.
Im not sure what to add under Infrastructure here, would a simple :
- Add functionality for utils (#1080) Be enough? Any help would be great.
@AwesomeSauce42 Which issue is this for? The issue number in the description doesn't appear to be valid.
@AwesomeSauce42 One of the new commits is missing the signoff. You can fix by following the instructions in https://github.com/opensearch-project/oui/pull/1080/checks?check_run_id=17733550749 Also, please add an entry to the Changlelog file, under the "Infrastructure" section.
Im not sure what to add under Infrastructure here, would a simple :
* Add functionality for utils ([#1080](https://github.com/opensearch-project/oui/pull/1080)) Be enough? Any help would be great.
In the Changelog entries, we're aiming to capture the impact of the change, so generally more of the "why" than the "how" or "what". So potentially something like "Improve organization of build scripts by isolating utilities (#1080)". (It can go under the Refactor section)
@AwesomeSauce42 Just checking in on the progress of this - have you had a chance to look at the feedback, or do you have other questions about the next steps? I'm marking it as a draft for now.
@AwesomeSauce42 Just checking in on the progress of this - have you had a chance to look at the feedback, or do you have other questions about the next steps? I'm marking it as a draft for now.
Yes, I've made the changes on my local, but I'm having issues with my github pushes, I have been getting the error: ! [rejected] feat/shash -> feat/shash (non-fast-forward) error: failed to push some refs to 'https://github.com/AwesomeSauce42/oui.git' hint: Updates were rejected because the tip of your current branch is behind hint: its remote counterpart. Integrate the remote changes (e.g. hint: 'git pull ...') before pushing again. hint: See the 'Note about fast-forwards' in 'git push --help' for details."
Have been trying to fix this but getting stuck here.
Hi, I've made the changes that were required. Could you check this once? I'm still new to this so it took a little time, apologies for the same.