Josh Romero

Results 125 comments of Josh Romero
trafficstars

How well do we understand or cover all the functionality of these components? Should part of this conversion process to add enough functional testing to make sure we maintain feature...

+1 to the idea of extending the existing dark/light theming to support custom themes. However, one thing to consider is whether dark vs light is still a separate concept -...

I also ran into a lot of this duplicated code as part of https://github.com/opensearch-project/OpenSearch-Dashboards/pull/1586, and was able to simplify some things in place, but as @tmarkley's review comments indicate, much...

@btzeng @ahopp I'm definitely a fan of adding this feature, but have a couple questions and concerns about the ramifications of this approach that may warrant further discussion. --- ##...

We had a chat today where we talked about the larger context that this feature fits into (including other "anywhere" projects that will also be adding more features to dashboard...

Thanks @jimkaba, it's always super useful to have specific user feedback like that! I think this is still very much a feature we intend to implement.

I came here to add to the discussion, but I mostly just have agreement, particularly with @AMoo-Miki's general approach.

> Our current implementation already stores all the default opensearch logos' and marks' svg images in an asset folder (src/core/server/core_app/assets/default_branding). We can move this folder to a root level folder...