Joshua Hannan

Results 201 comments of Joshua Hannan

Thanks @alxocity! Let me know if you have any questions or need any help! :)

Thank you for offering to help @marcusmolchany! Yeah, I kind of just intended it for string replacing the addresses, but there is another PR in the core contracts repo that...

@phouse512 we don't have a critical need for it, but it is always helpful to have more good smart contract examples of different use cases! It would be awesome if...

I would like to get the tests moved to overflow also, but it hasn't really been a priority yet. Bjarte was kind enough to provide some examples for how it...

Yes, that is it. If you're interested in helping, you're welcome to make a PR. My only desire is that we keep all the non-cadence stuff in the `lib/` directory...

We decided to use flow-js-testing for this [in this PR](https://github.com/onflow/flow-nft/pull/116), so we won't be using overflow in this repo for now. I'll look into using it in other repos though

@psiemens @EricLin2004 Would you be able to elaborate a bit more on what is required for this? I want to make sure this is pretty clear

Here are two documents that our legal team has put together for how we envision this. I'll try to respond again later this week with some ideas for how I...

![Screen Shot 2022-07-18 at 2 22 59 PM](https://user-images.githubusercontent.com/7407828/179601043-ac998aaf-cf37-43ad-9715-c3ac84ad7914.png) ![Screen Shot 2022-07-18 at 2 23 11 PM](https://user-images.githubusercontent.com/7407828/179601050-ab8cad31-f940-4efb-be44-9350e3d5869a.png)