Joshua Hannan

Results 201 comments of Joshua Hannan

@jribbink I'm not sure what the errors in the CI mean. They don't look like Cadence errors. Mostly seeing: * `TypeError: Cannot read properties of undefined (reading 'kill')` * `thrown:...

Is it okay if I just merge this? Does it matter if the integration tests are completely passing or not since we're deprecating nft catalog anyway?

Can we close this since we've deprecated NFT Catalog in favor of TokenList?

This causes a bug in the new token standards that I missed testing while we were iterating. Just fell through the cracks, so I take responsibility for missing it. As...

@SupunS @turbolent Can you take a look at this? This is preventing people from being able to update their contracts with all the functionality in the token standards

This is different than the discussion about the `Burner` contract IMO. This is a function that, if there was an override implementation, would be accessible in the implementing contract, so...

Like, if I were to make this function `access(all)`, then my implementation contract could call the function default implementation via my contract (the implementation) even if my contract hasn't provided...

Well, I definitely wouldn't want to restrict it any more because that would break the `Burner` contract! 😅 If we were to restrict it more, we would need a new...

@turbolent It is on hold right now while we wrap up some technical debt. Also, flowty and find were working on UniversalCollection contracts, so [we need to review those](https://github.com/onflow/dx-internal/issues/2) soon...

Closing in favor of just pointing people to Austin's version