Joshua Hannan

Results 201 comments of Joshua Hannan

@jonwalch I don't think that a lending standard belongs in the core NFT standard, but we're happy to provide feedback on one if you would like to give it a...

Thanks for commenting! Your concern actually won't be an issue any more after the June spork. I don't know if you've been paying attention to FLIPs, but [Cadence has been...

Yes, we definitely think that is important @bjartek. We're actually finishing up a proposal for our refactoring of the token standards and your point is a big part of the...

I just pushed changes to the standard based on the discussions we've been having in the standard breakout sessions, including events emitted from interfaces. > Would it be possible at...

It is kind of similar to the `msg.sender` problem. If we had a field on every vault that was the previous owner, it would be easy to spoof that and...

@dryruner like bjarte said, you should be able to dynamically borrow a contract with `ViewResolver` because most token contracts will implement `ViewResolver`, and you can use that to get the...

There is also no way to enforce that token contracts implement `FungibleToken`, so the same problem still exists even if it is an interface. And this change won't be live...

To follow up for anyone watching, we decided to change both standards back to interfaces. Summary of the discussion can be found in [the FLIP](https://github.com/onflow/flips/pull/55#issuecomment-1898982874)

We finalized the design of the standards at our last working group meeting and this PR has been updated with the intended final implementations of `FungibleToken`, `FungibleTokenMetadataViews`, and `Burner`. Anyone...

I just marked this PR as ready for review! There are still some tests that need to be added, but I consider most of the code to be ready! I'm...