flow-nft icon indicating copy to clipboard operation
flow-nft copied to clipboard

Move testing to use Overflow

Open austinkline opened this issue 2 years ago • 4 comments

Issue to be solved

The tests in this repo aren't using either of the main testing libraries out there (overflow and flow-js-testing). Given that this repo's tests are in Go, I'd like to get tests moved to overflow.

https://github.com/bjartek/overflow

austinkline avatar Jul 12 '22 15:07 austinkline

I would like to get the tests moved to overflow also, but it hasn't really been a priority yet. Bjarte was kind enough to provide some examples for how it might work though, so we might be able to do it sometime soon.

joshuahannan avatar Jul 12 '22 20:07 joshuahannan

I would like to get the tests moved to overflow also, but it hasn't really been a priority yet. Bjarte was kind enough to provide some examples for how it might work though, so we might be able to do it sometime soon.

Great to hear there's some interest internally about revamping the unit test frameworks being used! Any chance provided examples can be attached if they aren't on the overflow github in case I find the time to start moving things over?

austinkline avatar Jul 12 '22 22:07 austinkline

This might be it! https://github.com/bjartek/flow-nft-overflow

austinkline avatar Jul 12 '22 23:07 austinkline

Yes, that is it. If you're interested in helping, you're welcome to make a PR. My only desire is that we keep all the non-cadence stuff in the lib/ directory if possible. If nobody else gets to it soon, I'll probably try to work on it in a few weeks

joshuahannan avatar Jul 13 '22 15:07 joshuahannan

We decided to use flow-js-testing for this in this PR, so we won't be using overflow in this repo for now. I'll look into using it in other repos though

joshuahannan avatar Aug 30 '22 15:08 joshuahannan