Josh Lory

Add back non-WebGL ocean overlay

1

Resurrect the changes in [PR #529](https://github.com/code-dot-org/craft/pull/529/files#diff-894dfbadc994764b5b510d470f495021L675) to draw the underwater overlay without the WebGL shader. Not clear yet if the shader is causing issues on low-end Chromebooks, but creating this...

Update the demo to work in IE11

1

I don't think we'll want to merge this until we _also_ ship the unbuild files to npm. Otherwise we'll double-include the `babel-polyfill` when importing the built `dist/main.js` in the main...

Refactor 37 lines occurring 3 times in 3 files: Creeper.js, IronGolem.js, Zombie.js

1

I've selected for refactoring 37 lines of code which are duplicated in 3 file(s) ([1](https://github.com/code-dot-org/craft/blob/9db1d6c80e8832e06ef0fdef4e092038b0a6b47a/src/js/game/Entities/Creeper.js#L33-L76), [2](https://github.com/code-dot-org/craft/blob/9db1d6c80e8832e06ef0fdef4e092038b0a6b47a/src/js/game/Entities/IronGolem.js#L32-L75), [3](https://github.com/code-dot-org/craft/blob/9db1d6c80e8832e06ef0fdef4e092038b0a6b47a/src/js/game/Entities/Zombie.js#L99-L142)). Addressing this will make our codebase more maintainable and improve [Better Code Hub](https://bettercodehub.com)'s...

`gameControllerConfig.Phaser` is only used in GameController.js: https://github.com/code-dot-org/craft/blob/3c2fc9506136fd32164ea8c3cadd826acb53a07e/src/js/game/GameController.js#L45 But all of LevelView.js still references the global `window.Phaser`: https://github.com/code-dot-org/craft/blob/3c2fc9506136fd32164ea8c3cadd826acb53a07e/src/js/game/LevelMVC/LevelView.js#L30

Ref: https://github.com/code-dot-org/craft/blob/70e7f4f09f6ee9bc2ce011f89b5ec28f36fab949/demo/js/phaser.js

Fix z-order clipping of boat oars

1

Expected behavior:  Actual: 

Optimize underwater music, add .ogg files

1

The added aquatic 01-03 mp3 files are much larger than previous years. We'll also need the .ogg version for our sound player. https://github.com/code-dot-org/craft/blob/5a8b2378b4bfb0e7d9d68de4b768ca947455e9df/src/assets/audio/ogg2mp3#L1-L2  The nether music from last year...

Why are there two (that aren't always set consistently)?

See https://github.com/code-dot-org/craft/issues/374#issuecomment-339499640. We've been approximating this with the "Invisible" block type, but this is fragile and breaks when we import new versions of Blocks.json. https://github.com/code-dot-org/craft/blob/ffb56b9281db1b3201c1e866856f12e319fd4ba9/src/js/game/LevelMVC/LevelBlock.js#L77-L82 On October 29, 2018 I...

Merge "actionPlane" and "groundDecorationPlane"

1

See https://github.com/code-dot-org/craft/pull/507#pullrequestreview-165340120. We think this is a remnant from the first year, where action plane blocks were collideable, but decoration plane blocks were not.