craft icon indicating copy to clipboard operation
craft copied to clipboard

We implicitly depend on global Phaser in some places, not the Phaser passed in to the constructor

Open joshlory opened this issue 6 years ago • 0 comments

gameControllerConfig.Phaser is only used in GameController.js:

https://github.com/code-dot-org/craft/blob/3c2fc9506136fd32164ea8c3cadd826acb53a07e/src/js/game/GameController.js#L45

But all of LevelView.js still references the global window.Phaser:

https://github.com/code-dot-org/craft/blob/3c2fc9506136fd32164ea8c3cadd826acb53a07e/src/js/game/LevelMVC/LevelView.js#L30

joshlory avatar Jan 18 '19 18:01 joshlory