Josh McKinney

Results 110 comments of Josh McKinney

I'll wait on @EdJoPaTo's approval to merge this

Some final tweaks: It's important to look the absolute magnitude of a perf gain, and not just the relative amount. On my M2 mac, removing the fast path costs ~30ns....

I'd like to get this released (perhaps Monday if @orhun is up to it). Direct link to the current file as of the last commit: https://github.com/ratatui-org/ratatui/blob/43118c5494f5218332319a41eb742a51138d7e3c/src/text/line.rs#L555 > It somewhat worries...

> 10 µs * 450 = 4.5 ms. 60 FPS are 16.66 ms Let's look at the absolute magnitude of the change though: (10 * .125) = 1.25us per call...

> Is there a reason why this was not done with `pos_of` too? I don't think `pos_of` should be part of the API, and I'd prefer not to make it...

I actually intended to put the deprecation of the existing methods in https://github.com/ratatui-org/ratatui/pull/1123, but accidentally pushed the commit to this PR. Happy to do it either way (though it would...

I think I'm with @EdJoPaTo on this one. Use the github team to manage users. I basically never check my github email notifications (as they're just a searchable backup of...

https://github.com/orgs/ratatui-org/teams/previous-maintainers/ created https://github.com/orgs/ratatui-org/teams/maintainers/ updated

I made a bunch of changes: - removed the prelude - revamped the way the data for the companies was stored to simplify the conversion into bars (i.e. it's stored...

The idea behind this is to do similar changes to all the examples, and to make them take this form.