Josh McKinney

Results 110 comments of Josh McKinney

I'd definitely like to see this happen. Taking a read through the source, I can see why it's not a trivial task to do like the linked PR. The CLI-ness...

I wonder if I'm in the minority in thinking that the actual bug is that the text of a toot (which is not a link) is clickable as if it's...

@Valentin271 This one is surprisingly difficult to get right, and likely needs to land on the tui lib in use not the app itself. Our oldest open issue in Ratatui...

Hrm, that sounds annoying :)

Two spans makes it possible to use `&strs`, one span would mean that an owned string would have to be constructed from the two lines. I think we currently just...

> Well the problem is that we can't add #[cfg(feature = "unstrable-widget-ref")] to the impl because it would break code not using the feature. It could be in fututre realease...

> * `TableMode::SingleSelection` and `TableMode::MultipleSelection` Perhaps move `Selection` to the name of the enum? (I wouldn't be surprised if there is a pedantic lint for that). I suspect this should...

Generally most widgets / controls in other frameworks will have a flag that is set to enable multi select. This is not generally enabled by default. It feels a bit...

I think (could be worng) Selection and Highlight are the two concept names I'd use for what you're calling Mark and Selection. I'm not 100% sure of this though.

> We unfortunately already have `TableState::select`, `TableState::selected` and `TableState::with_selected`, so it'd be a breaking change to do it that way. Yeah, I think this is a difficult one to get...