Ayush Joshi

Results 23 comments of Ayush Joshi

@derekmauro Tell me if you are open to accepting a PR that fixes this issue.

> Could you please explain how you encountered this issue? @dinord Personally I didn't encounter this issue but it may become an issue in case `base_name` is empty. I was...

@cramertj Could you please elaborate on the following: > users aren't confused why their command line flags aren't being parsed When exactly does that happen? > they don't then have...

@derekmauro Are there any plans to include what @cramertj says? > Consider calling `absl::ParseCommandLine` from `gtest_main` (or a similar ABSL-specific testing main file) This seems to be a good enhancement,...

@derekmauro Sorry my previous commit https://github.com/google/googletest/pull/3703 was directly on the main branch of my fork and I did not realise it 😅, yes I know I sound stupid.

@MikeChan-HK Like my previous PR https://github.com/google/googletest/pull/3703 this one again didn't pass Windows, please guide me I'm not familiar with gmock yet. The reason why I asked you is because you...

@dinord Hey is this PR even visible from your end or I'm stuck in some kind of parallel earth? I'm not sure but in case you see this don't forget...

> This is failing on windows, and the reason seems to be that it's inserting `\r` before each `\n`, causing the output to be different from the golden file. Is...